Skip to content

Commit 7731fbd

Browse files
author
hawk0620
committed
remove unnecessary weak and strong self reference
1 parent d624934 commit 7731fbd

File tree

1 file changed

+0
-25
lines changed

1 file changed

+0
-25
lines changed

SDWebImage/Core/SDImageCachesManager.m

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -441,12 +441,7 @@ - (void)serialQueryImageForKey:(NSString *)key options:(SDWebImageOptions)option
441441
}
442442
return;
443443
}
444-
@weakify(self);
445444
[cache queryImageForKey:key options:options context:context cacheType:queryCacheType completion:^(UIImage * _Nullable image, NSData * _Nullable data, SDImageCacheType cacheType) {
446-
@strongify(self);
447-
if (!self) {
448-
return;
449-
}
450445
if (operation.isCancelled) {
451446
// Cancelled
452447
return;
@@ -479,12 +474,7 @@ - (void)serialStoreImage:(UIImage *)image imageData:(NSData *)imageData forKey:(
479474
}
480475
return;
481476
}
482-
@weakify(self);
483477
[cache storeImage:image imageData:imageData forKey:key options:options context:context cacheType:cacheType completion:^{
484-
@strongify(self);
485-
if (!self) {
486-
return;
487-
}
488478
// Next
489479
[self serialStoreImage:image imageData:imageData forKey:key options:options context:context cacheType:cacheType completion:completionBlock enumerator:enumerator];
490480
}];
@@ -500,12 +490,7 @@ - (void)serialRemoveImageForKey:(NSString *)key cacheType:(SDImageCacheType)cach
500490
}
501491
return;
502492
}
503-
@weakify(self);
504493
[cache removeImageForKey:key cacheType:cacheType completion:^{
505-
@strongify(self);
506-
if (!self) {
507-
return;
508-
}
509494
// Next
510495
[self serialRemoveImageForKey:key cacheType:cacheType completion:completionBlock enumerator:enumerator];
511496
}];
@@ -523,12 +508,7 @@ - (void)serialContainsImageForKey:(NSString *)key cacheType:(SDImageCacheType)ca
523508
}
524509
return;
525510
}
526-
@weakify(self);
527511
[cache containsImageForKey:key cacheType:cacheType completion:^(SDImageCacheType containsCacheType) {
528-
@strongify(self);
529-
if (!self) {
530-
return;
531-
}
532512
if (operation.isCancelled) {
533513
// Cancelled
534514
return;
@@ -561,12 +541,7 @@ - (void)serialClearWithCacheType:(SDImageCacheType)cacheType completion:(SDWebIm
561541
}
562542
return;
563543
}
564-
@weakify(self);
565544
[cache clearWithCacheType:cacheType completion:^{
566-
@strongify(self);
567-
if (!self) {
568-
return;
569-
}
570545
// Next
571546
[self serialClearWithCacheType:cacheType completion:completionBlock enumerator:enumerator];
572547
}];

0 commit comments

Comments
 (0)