Skip to content

refactor(ui5-label): wrap text by default#8935

Merged
dimovpetar merged 2 commits intomainfrom
label_default_wrapping
May 10, 2024
Merged

refactor(ui5-label): wrap text by default#8935
dimovpetar merged 2 commits intomainfrom
label_default_wrapping

Conversation

@dimovpetar
Copy link
Copy Markdown
Member

@dimovpetar dimovpetar commented May 10, 2024

The text of ui5-label now wraps by default.

BREAKING CHANGE: wrapping-type property default value has changed from None to Normal.
Before:

<ui5-label>some very very very long label</ui5-label> <!-- would truncate the text if there is not enough space -->

Now:

<ui5-label>some very very very long label</ui5-title> <!-- would let the text wrap if there is not enough space -->

Related to #8461

@alexandar-mitsev
Copy link
Copy Markdown
Member

LGTM , waiting for UA approval

@dimovpetar dimovpetar requested a review from BorisDafov May 10, 2024 13:17
Copy link
Copy Markdown

@BorisDafov BorisDafov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the PR from UA perspective.

@dimovpetar dimovpetar merged commit 5b7db03 into main May 10, 2024
@dimovpetar dimovpetar deleted the label_default_wrapping branch May 10, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants