Conversation
ui5-badge to Tag ui5-tag
Closed
vladitasev
approved these changes
May 2, 2024
GerganaKremenska
previously approved these changes
May 2, 2024
|
|
||
| #XACT: ARIA announcement for the badge | ||
| BADGE_DESCRIPTION_BADGE=Badge | ||
| TAG_DESCRIPTION_BADGE=Badge |
Contributor
There was a problem hiding this comment.
Since we renmed the component, maybe it is reduntant to have "TAG_DESCRIPTION_BADGE" and confusing. We can leave only "Tag description", uneless there is some use case that we need the badge description?
Contributor
Author
There was a problem hiding this comment.
I was thinking about this, and probably yes, but I will leave this to the team, as there will be some follow-up alignments - from what I heard one of the design sets could be even removed, and if it's "Set3", then the text in question will be naturally removed.
So I suggest merging it now, the pure refactoring, and later you can remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename Badge to Tag - tags, styles, classes to match with the SAP Design Tag concept.
BREAKING CHANGE: Badge web component has been renamed to Tag.
ui5-badgeui5-tagui5-badgehas been renamed to Tagui5-tag. If you have previously used theui5-badge:Now use
ui5-taginstead: