feat(ui5-menu-separator): add new component#8871
Conversation
|
The "Now:" section of the commit description still contains the removed property ( |
BorisDafov
left a comment
There was a problem hiding this comment.
I suggest to rename the "Usage" section to "Structure" (lines 62-65), and to include the information about the ui5-menu-separator there:
Structure
Can hold two types of entities:
• ui5-menu-item components.
• ui5-menu-separator to separate menu items with a line.
An arbitrary hierarchy structure can be represented by recursively nesting menu items.
tsanislavgatev
left a comment
There was a problem hiding this comment.
There is hover effect over the menu-separator in the menu. And we need to fix it.
setting the pointer events to none might do the job.
Setting pointer events to none will cause the focus to go back to the parent, but I removed the hover effect with css |
nnaydenow
left a comment
There was a problem hiding this comment.
Also the API of the component looks strange when all jsdoc related comments are addressed:
We reworked the separator and it no longer inherits from ListItem so those properties and elements are not being inherited either :) |
unazko
left a comment
There was a problem hiding this comment.
The code looks clean with the new changes and works as expected.
|
Retested. The solution continues to work as expected. |
New component that can be slotted with menu items
BREAKING CHANGE:
startsSectionproperty removed from MenuItemsBefore:
Now:
Related to: #8461