Merged
Conversation
nnaydenow
requested changes
Apr 26, 2024
Contributor
nnaydenow
left a comment
There was a problem hiding this comment.
To things to discuss:
- some of the css classes related to value states are renamed and others not
- should we find and replace all value state translations texts for consistency?
Contributor
Author
|
nnaydenow
approved these changes
Apr 27, 2024
Closed
nnaydenow
pushed a commit
that referenced
this pull request
Apr 29, 2024
The base ValueState enum values have been changed from ValueState.Warning, ValueState.Error and ValueState.Success to ValueState.Critical, ValueState.Negative and ValueState.Positive, causing changes in multiple components supporting valueState property (+ properties of similar type as Dialog.state, StandardListItem.highlight and MessageStrip.design). BREAKING CHANGE: If you previously used ValueState.Warning, ValueState.Error or ValueState.Success, start using ValueState.Critical, ValueState.Negative and ValueState.Positive respectively. All components with valueState property are also affected. For example: ```html <ui5-input value-state="Success"></ui5-input> <ui5-input value-state="Warning"></ui5-input> <ui5-input value-state="Error"></ui5-input> ``` ```html <ui5-input value-state="Positive"></ui5-input> <ui5-input value-state="Critical"></ui5-input> <ui5-input value-state="Negative"></ui5-input> ``` Related to: #8461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base ValueState enum values have been changed from
ValueState.Warning,ValueState.ErrorandValueState.SuccesstoValueState.Critical, ValueState.Negative andValueState.Positive, causing changes in multiple components supporting valueState property (+ properties of similar type asDialog.state,StandardListItem.highlightandMessageStrip.design).BREAKING CHANGE: If you previously used
ValueState.Warning,ValueState.ErrororValueState.Success, start usingValueState.Critical,ValueState.NegativeandValueState.Positiverespectively. All components withvalueStateproperty are also affected:Related to: #8461