Skip to content

feature(ui5-option): tooltip property added#8827

Merged
yanaminkova merged 3 commits intomainfrom
ui5-option2.0
Apr 30, 2024
Merged

feature(ui5-option): tooltip property added#8827
yanaminkova merged 3 commits intomainfrom
ui5-option2.0

Conversation

@yanaminkova
Copy link
Copy Markdown
Contributor

@yanaminkova yanaminkova commented Apr 23, 2024 •
edited
Loading

The private title property, previously available in the ui5-option component, has been removed.
It is replaced by a new property named tooltip, used for defining the text of the tooltip that would be displayed for the ui5-option component.
Now, you can set the tooltip of the ui5-option as it follows:

<ui5-select id="selectTooltip">
    <ui5-option tooltip="Cozy">Cozy</ui5-option>
    <ui5-option tooltip="Compact">Compact</ui5-option>
    <ui5-option selected tooltip="Condensed">Condensed</ui5-option>
</ui5-select>

Related to: #8461, #7887

@nnaydenow
Copy link
Copy Markdown
Contributor

nnaydenow commented Apr 24, 2024

Hi @yanaminkova,

This PR seems to be more like feature instead of refactoring. Please change the PR title and remove breaking change label.

@yanaminkova yanaminkova changed the title refactor(ui5-option): tooltip property added feature(ui5-option): tooltip property added Apr 24, 2024
nnaydenow
nnaydenow requested changes Apr 24, 2024
View reviewed changes
@yanaminkova yanaminkova requested a review from nnaydenow April 25, 2024 07:35
nnaydenow
nnaydenow requested changes Apr 25, 2024
View reviewed changes
nnaydenow
nnaydenow approved these changes Apr 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanaminkova yanaminkova merged commit 34311c0 into main Apr 30, 2024
@yanaminkova yanaminkova deleted the ui5-option2.0 branch April 30, 2024 05:47
@ilhan007 ilhan007 mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dobrinyonkov dobrinyonkov dobrinyonkov approved these changes

@nnaydenow nnaydenow nnaydenow approved these changes

Assignees

No one assigned

Labels

2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yanaminkova @nnaydenow @dobrinyonkov