refactor(ui5-illustrated-message): remove titleLevel property#8700
Merged
yanaminkova merged 3 commits intomainfrom Apr 24, 2024
Merged
refactor(ui5-illustrated-message): remove titleLevel property#8700yanaminkova merged 3 commits intomainfrom
yanaminkova merged 3 commits intomainfrom
Conversation
nnaydenow
requested changes
Apr 24, 2024
nnaydenow
approved these changes
Apr 24, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
titleLevelproperty of theui5-illustrated-message, since users can set the required title level on the title slot.Also, now the the slotted element has proper styles and responsiveness.
BREAKING CHANGE: The
titleLevelproperty of theui5-illustrated-messageis removed.If you have previously used the
titleLevelproperty:it will no longer work for the component.
Instead, you could set the title of the
ui5-illustrated-messageon thetitleslot, as it followsRelated to #8461, #7887