Skip to content

[INTERNAL] Memory Adapter: Clone resource on write#259

Closed
RandomByte wants to merge 1 commit intov2from
memory-clone-on-write
Closed

[INTERNAL] Memory Adapter: Clone resource on write#259
RandomByte wants to merge 1 commit intov2from
memory-clone-on-write

Conversation

@RandomByte
Copy link
Copy Markdown
Member

@RandomByte RandomByte commented Jul 14, 2020

To create a behavior similar to the FS Adapter. Follow up of #235

@RandomByte RandomByte requested review from matz3 and tobiasso85 July 14, 2020 09:52
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 14, 2020

Coverage Status

Coverage decreased (-0.03%) to 86.788% when pulling 72f5846 on memory-clone-on-write into dfe1c41 on master.

matz3
matz3 previously approved these changes Jul 14, 2020
To create a behavior similar to the FS Adapter, ensuring that a
resources content can not be changed after it has been written.
matz3
matz3 previously approved these changes Jul 14, 2020
@RandomByte
Copy link
Copy Markdown
Member Author

This PR breaks tests in ui5-builder

@flovogt
Copy link
Copy Markdown
Member

flovogt commented Dec 1, 2022

Superseded by #448.

@flovogt flovogt closed this Dec 1, 2022
@flovogt flovogt deleted the memory-clone-on-write branch December 15, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants