[FIX] Enable buildThemes for libraries without .library#671
Merged
larskissel merged 1 commit intomasterfrom Dec 6, 2021
Merged
[FIX] Enable buildThemes for libraries without .library#671larskissel merged 1 commit intomasterfrom
larskissel merged 1 commit intomasterfrom
Conversation
Fixes that libraries using a "library.js" file but no ".library" file can also build theming files. Fixes: UI5/cli#582
Member
|
LGTM 👍🏻 @RandomByte any opinion whether we want to have this in v2.x or only in v3.x? IMO we should do it in both versions. |
Member
|
Merging this into master and releasing as a v2 patch is also fine with me. We should then do a cherry-pick to |
matz3
approved these changes
Dec 3, 2021
Member
Author
|
cherry-pick to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that libraries using a "library.js" file but no ".library"
file can also build theming files.
Fixes: UI5/cli#582