Propagate taint through StringIterator (fixes #348)#349
Conversation
|
Looks good as far as I can see. Could you add a mochitest? Generally, we apologize for the delay in merging PRs at the moment. We are currently busy preparing a Foxhound demo for Blackhat. |
|
Here we go! I also replaced PS: I'm glad that you are going to present Foxhound to Blackhat. Unfortunately I will not be able to join the event for lack of funding :( |
|
Sadly, blackhat is super expensive... What is possible is to get a business hall ticket (it'll include the Arsenal stuff we are doing, but you are missing out on talks) so it is fairly cheap.. But still, it's like roughly 1k euros for flights (more expensive from italy I assume) and hotel.. |
|
Extra commit in which I copy the single-character string before setting the taint. I guess that strings of that kind are stored in a sort of cache, because when I executed the code |
This pull request enables taint propagation through StringIterator. Therefore, it fixes #348.
In local, we verified the following test cases:
[..."abc"].map(x => x.taint)[...String.tainted("abc", "t1")].map(x => x.taint)[...(String.tainted("abc", "t1") + String.tainted("def", "t2"))].map(x => x.taint)[..."a😊c"].map(x => x.taint)