Fix incorrect taint range assignment on JSON.stringify (fixes #345)#346
Merged
Conversation
Collaborator
|
The fix itself looks good! Could you maybe add a mochitest to verify we do not cause regressions over time? |
Collaborator
|
so, I'll merge this to enable moving the big rebase forward. It'd still be great if you could open a second PR with 1-2 mochitests :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #345. Substantially, it reimplements the taint propagation logic in InfallibleQuoteJSONString (js/src/builtin/JSON.cpp). Also, it removes the use of appendTaintIfRequired and the "probably not very efficient" concern, as taint ranges are no longer added character-wise.