Skip to content

Towards a useful debug mode#314

Merged
leeN merged 4 commits into
SAP:mainfrom
leeN:debug_mode
Aug 8, 2025
Merged

Towards a useful debug mode#314
leeN merged 4 commits into
SAP:mainfrom
leeN:debug_mode

Conversation

@leeN

@leeN leeN commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator

Currently, compiling with --enable-debug results in a binary that crashes on startup. This PR resolves some of the issues I encountered.

This includes a fix for #308 and several other assertions failures.

To be able to properly use debug mode, there are some remaining issues:

@leeN leeN marked this pull request as draft June 18, 2025 11:42
@leeN leeN added bug Something isn't working Debug Mode labels Jun 18, 2025
@leeN leeN self-assigned this Jun 18, 2025
@leeN leeN marked this pull request as ready for review August 7, 2025 15:01
@leeN

leeN commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

So, as we wanted to reduce the number of open pull requests, I would say we can merge this as a partial solution. The preferences aspect is a bigger rewrite and the tainting on shutdown requires more work than I have capacity at this point in time.

@leeN leeN requested a review from tmbrbr August 7, 2025 15:02
@leeN leeN merged commit 59712bf into SAP:main Aug 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Debug Mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants