Xhr response text tests#298
Merged
Merged
Conversation
8182fba to
43e1c9b
Compare
tmbrbr
reviewed
Jun 10, 2025
43e1c9b to
15c5bbf
Compare
tmbrbr
previously approved these changes
Jun 16, 2025
Added tests for treating the respone of an XHR object as: - text: works - json: Added in this commit - HTML: does not work yet - XML: does not work yet
15c5bbf to
b905d90
Compare
Fixes some bugs where end-to-end taints where not propagated into XHR.responses.
Collaborator
Author
|
Ah, I rebased this onto the e2e branch and added taint propagation + tests. Can you re-review this? |
b54d6df to
273530c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for issue #294, which work. Weird stuff! Depends on #297.