Can we meaningfully taint empty strings? TryEmptyOrStaticString says they are super common, so maybe the "cleaner" way would be to change the logic here and only remove the static string lookup for non empty strings? or to move the following check over:

    if (n == 0) {
      return cx->emptyString();
    }

Can we meaningfully taint empty strings? TryEmptyOrStaticString says they are super common, so maybe the "cleaner" way would be to change the logic here and only remove the static string lookup for non empty strings? or to move the following check over:

    if (n == 0) {
      return cx->emptyString();
    }

Good idea, I just checked and all of the TryEmptyOrStaticString are now commented out by us! So I think the best strategy is to re-enable them, and disable the static string part centrally in TryEmptyOrStaticString itself.

Something like this? ☝️