Upload build artifacts#263
Merged
Merged
Conversation
Contributor
Author
|
At the moment the binaries are being uploaded successfully for all jobs except on the windows runners. In this case the builds are failing due to de-sync of MSCV on the github runner and the clang version used by mozbuild. (See here for a similar issue. We can't just update the clang version in the image because Firefox downloads its own version. This will hopefully be fixed once the Firefox version is updated (e.g. in #262). |
Contributor
Author
|
Now that #262 is merged, this should hopefully work now, I'll rebase. |
The issue is that mach installs its own llvm version, which is now incompatible with the latest github runner.
949746a to
8bc6cb6
Compare
Contributor
Author
|
Seems to be working after the update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploading artifacts from the browser builds for the recently added Github actions.