String conversion bug#249
Merged
Merged
Conversation
|
|
tmbrbr
reviewed
Jan 16, 2025
tmbrbr
requested changes
Jan 17, 2025
tmbrbr
left a comment
Contributor
There was a problem hiding this comment.
Just a small question about the mochitests.
tmbrbr
approved these changes
Jan 21, 2025
tmbrbr
approved these changes
Jan 23, 2025
This was referenced Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The taint was being lost for string conversion due to fast path being taken when classes were being used. The taint was also being lost for utf8 conversion (special case). Both issues have been fixed and tested. This fix is for issue #238 and #240 .