Skip to content

Adding Rust installation to build script#231

Merged
tmbrbr merged 1 commit into
SAP:mainfrom
tmbrbr:build-script-rust
Oct 16, 2024
Merged

Adding Rust installation to build script#231
tmbrbr merged 1 commit into
SAP:mainfrom
tmbrbr:build-script-rust

Conversation

@tmbrbr

@tmbrbr tmbrbr commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

Adding rust installation to the build script.

Normally this is done by the ./mach bootstrap command, but this is not ideal for the build script for a couple of reasons:

  • Removing the --no-system-changes would also do this, but also install system packages which requires root privileges. We want to avoid needing a sudo command.
  • By default, mach will install the latest version of rust, which may be too new by the time we get around to building. By installing ourselves, we can control the rust version which matches the firefox version (https://firefox-source-docs.mozilla.org/writing-rust-code/update-policy.html)

This patch maintains the rust version in the .PLAYWRIGHT_VERSION file and makes sure it gets installed.

@tmbrbr tmbrbr requested a review from leeN October 16, 2024 11:02

@leeN leeN left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tmbrbr tmbrbr merged commit 95befff into SAP:main Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants