Skip to content

Re-enabling end2end tainting#112

Closed
tmbrbr wants to merge 8 commits into
SAP:mainfrom
tmbrbr:end2end
Closed

Re-enabling end2end tainting#112
tmbrbr wants to merge 8 commits into
SAP:mainfrom
tmbrbr:end2end

Conversation

@tmbrbr

@tmbrbr tmbrbr commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

This pull request includes:

  • Decoding the "X-Taint" HTTP header as taint ranges and attaching to the stream
  • Re-enabling taint propagation across various Firefox internal streams
  • Fixing HTML decoding to support taint propagation
  • Fixing JavaScript parsing to support taint propagation
  • Updating test scripts

@tmbrbr tmbrbr self-assigned this Feb 3, 2023

@tmbrbr tmbrbr left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up whitespace issues

MOZ_ASSERT(aParent, "Null parent");
MOZ_ASSERT(!aStart, "aStart must always be zero.");

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace!

JSContext* aCx, JSExecutionContext& aExec, ScriptLoadRequest* aRequest) {
nsAutoCString profilerLabelString;
aRequest->GetProfilerLabel(profilerLabelString);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace

assertSourceParserAndScriptCreated();

TokenStreamPosition startPosition(parser->tokenStream);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More Whitespace

Comment thread js/src/frontend/TokenStream.h Outdated
}

// This is the low-level interface to the JS source code buffer. It just gets
// This is the low-level interface to the JS source code buffer. It eUnits(just gets

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

// TaintFox: propagate taint.
AppendTaintAt(GetLength(), aTaint);


Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WhiteSpace

Comment thread xpcom/io/nsPipe3.cpp
uint32_t aCount, uint32_t* aReadCount) {
LOG(("III ReadSegmentsInternal [this=%p count=%u]\n", this, aCount));
MOZ_ASSERT(!aWriter || !aTaintedWriter, "one of aWriter and aTaintedWriter must be null");

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WhiteSpace

@tmbrbr tmbrbr added the enhancement New feature or request label May 11, 2023
@tmbrbr tmbrbr mentioned this pull request Jun 17, 2025
@tmbrbr

tmbrbr commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

This merge is stale and has been superseded by #307

@tmbrbr tmbrbr closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant