Update writerfactory so enums actually work#4
Merged
RyoTune merged 1 commit intoRyoTune:mainfrom Feb 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes enum handling in the ObjectWriters by adding an IsEnum check to the FieldWriterFactory. Previously, enum types were not being routed to PrimitiveFieldWriter, which has the necessary logic to handle enum values (both by name and by integer value).
Key Changes:
- Added
fieldType.IsEnumcheck to the condition for creating PrimitiveFieldWriter instances
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.