Skip to content

Remove useless dependencies and compat bounds in test environment#4

Closed
giordano wants to merge 1 commit intoRvSpectML:mainfrom
giordano:mg/test-proj
Closed

Remove useless dependencies and compat bounds in test environment#4
giordano wants to merge 1 commit intoRvSpectML:mainfrom
giordano:mg/test-proj

Conversation

@giordano
Copy link
Copy Markdown

@giordano giordano commented Mar 5, 2023

It'd be great to get a new release tagged after this PR is merged, this is causing spurious failures in PkgEval: JuliaLang/julia#47797 (comment)

@eford
Copy link
Copy Markdown
Member

eford commented Mar 6, 2023

Thanks for the suggestion. It seems that I do need to add LinearAlgebra and Polynomials back to the test/Project.toml for the tests to pass. Will that still solve the problems with PkgEval?

@giordano
Copy link
Copy Markdown
Author

giordano commented Mar 6, 2023

Oh, I kept only the packages listed in

using Scalpels
using Test
didn't notice there were includes. The main problem were the needlessly restrictive compat bounds, they're already set in the package itself.

@eford
Copy link
Copy Markdown
Member

eford commented Mar 6, 2023

Ok, I think I've fixed it in the latest released version. Let me know if it's still causing problems.

Sorry for the hassle. This was a relic of when I was totally confused by the new packaging system. The documentation has definitely improved, but I suspect that I'm not the only would who could benefit from a blog post explaining best practices for Projects, Manifests and Artifacts for the root dir of a package versus the test, documents, examples, input data files, etc. subdirectories.

@giordano
Copy link
Copy Markdown
Author

giordano commented Mar 6, 2023

Yes, that should be good now, thanks!

@giordano giordano closed this Mar 6, 2023
@giordano giordano deleted the mg/test-proj branch March 6, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants