Skip to content

Fix lint warnings in release.yml#7538

Merged
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:ci-release-warnings
Mar 30, 2026
Merged

Fix lint warnings in release.yml#7538
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:ci-release-warnings

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented Mar 30, 2026

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration: removed a workflow-level write permission and pinned several build/deploy actions to fixed revisions while preserving existing build targets and deploy behavior.
    • Formatting of one action's inputs adjusted for clarity.
    • No user-visible changes or functional impact to the product.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 3dd4efab-c650-4100-9a98-f1e1a0b71cd7

📥 Commits

Reviewing files that changed from the base of the PR and between bb54085 and f80f93e.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

Pins GitHub Actions used in the release workflow to specific commit SHAs, removes the workflow-level contents: write permission, and converts the WABT action's with configuration from an inline mapping to a multi-line mapping while keeping the same version values.

Changes

Cohort / File(s) Summary
GitHub Actions workflow configuration
/.github/workflows/release.yml
Removed workflow-level permissions: contents: write; pinned dtolnay/rust-toolchain@stable, mwilliamson/setup-wabt-action@v3, and peaceiris/actions-gh-pages@v4 to specific commit SHAs; changed with for WABT from inline to multi-line mapping (kept wabt-version: "1.0.30"); preserved deploy step inputs and conditions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

skip:ci

Suggested reviewers

  • youknowone

Poem

🐰 I hopped through YAML lines tonight,

Pinned each action snug and tight,
Took away a write of old,
Kept the versions, neat and bold,
Builds will hum without a fright.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix lint warnings in release.yml' accurately describes the main change - pinning GitHub Actions to specific commit SHAs and adjusting configuration structure to resolve lint warnings in the release workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

persist-credentials: false

- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
persist-credentials: false

- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
@ShaharNaveh ShaharNaveh force-pushed the ci-release-warnings branch from bb54085 to f80f93e Compare March 30, 2026 08:25
@youknowone youknowone merged commit 9900c76 into RustPython:main Mar 30, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants