Skip to content

Add correct __origname__ metadata for frozen modules #6523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Copilot wants to merge 3 commits into from
Closed

Add correct __origname__ metadata for frozen modules #6523

Copilot wants to merge 3 commits into from

Conversation

Copy link
Contributor

Copilot AI commented Dec 25, 2025 •
edited
Loading

  • Inspect current frozen module origname handling
  • Implement correct origname population for frozen modules
  • Add targeted tests for frozen module origname
  • Run targeted tests and verify results
  • Fix clippy warnings
Original prompt

This section details on the original issue you should resolve

<issue_title>Add proper origname to frozen module</issue_title>
<issue_description>## Feature

#4559 added __origname__ property but it doesn't contain actual origname.
</issue_description>

<agent_instructions>Correctly implement one. Reference for previous work: f53c686
</agent_instructions>

Comments on the Issue (you are @copilot in this section)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone
Fix frozen module origname metadata
70e96fd 
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
Copilot AI changed the title [WIP] Add proper __origname__ to frozen module Add correct __origname__ metadata for frozen modules Dec 25, 2025
Copilot AI requested a review from youknowone December 25, 2025 11:42
@youknowone
Copy link
Member

youknowone commented Dec 30, 2025

@copilot fix clippy failures

@youknowone
Fix clippy warning in frozen origname handling
a40da0c 
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 30, 2025

@copilot fix clippy failures

Addressed the clippy warning in core_frozen_inits by returning the mapped iterator directly (commit a40da0c).

@youknowone youknowone marked this pull request as ready for review December 31, 2025 09:27
@youknowone youknowone mentioned this pull request Dec 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone Awaiting requested review from youknowone

Assignees

@youknowone youknowone

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add proper __origname__ to frozen module

2 participants

@youknowone