Update stdlib/src/ssl.rs

youknowone · coderabbitai[bot] · youknowone · commit 4085720411b6 · 2025-10-27T20:55:42.000+09:00
Co-authored-by: coderabbitai[bot] &lt;136622811+coderabbitai[bot]@users.noreply.github.com&gt;
diff --git a/stdlib/src/ssl.rs b/stdlib/src/ssl.rs
@@ -1234,17 +1234,17 @@ mod _ssl {
         }
 
         #[pymethod]
-        fn get_verified_chain(&self, vm: &VirtualMachine) -> Option<PyListRef> {
+        fn get_verified_chain(&self, vm: &VirtualMachine) -> PyResult<Option<PyListRef>> {
             let stream = self.stream.read();
             unsafe {
                 let chain = sys::SSL_get0_verified_chain(stream.ssl().as_ptr());
                 if chain.is_null() {
-                    return None;
+                    return Ok(None);
                 }
 
                 let num_certs = sys::OPENSSL_sk_num(chain as *const _);
-                let mut certs = Vec::new();
 
+                let mut certs = Vec::with_capacity(num_certs as usize);
                 // Return Certificate objects
                 for i in 0..num_certs {
                     let cert_ptr = sys::OPENSSL_sk_value(chain as *const _, i) as *mut sys::X509;
@@ -1254,16 +1254,15 @@ mod _ssl {
                     // Clone the X509 certificate to create an owned copy
                     sys::X509_up_ref(cert_ptr);
                     let owned_cert = X509::from_ptr(cert_ptr);
-                    if let Ok(cert_obj) = cert_to_certificate(vm, owned_cert) {
-                        certs.push(cert_obj);
-                    }
+                    let cert_obj = cert_to_certificate(vm, owned_cert)?;
+                    certs.push(cert_obj);
                 }
 
-                if certs.is_empty() {
+                Ok(if certs.is_empty() {
                     None
                 } else {
                     Some(vm.ctx.new_list(certs))
-                }
+                })
             }
         }
 
@@ -2060,7 +2059,7 @@ mod _ssl {
                 // Need to set args[0] = SSL_ERROR_EOF for suppress_ragged_eofs check
                 None => {
                     return vm.new_exception(
-                        PySslSyscallError::class(&vm.ctx).to_owned(),
+                        PySslEOFError::class(&vm.ctx).to_owned(),
                         vec![
                             vm.ctx.new_int(SSL_ERROR_EOF).into(),
                             vm.ctx
diff --git a/stdlib/src/ssl/cert.rs b/stdlib/src/ssl/cert.rs
@@ -2,7 +2,7 @@ pub(super) use ssl_cert::{PySSLCertificate, cert_to_certificate, cert_to_py, obj
 
 // Certificate type for SSL module
 
-#[pymodule(name = "_ssl")]
+#[pymodule(sub)]
 pub(crate) mod ssl_cert {
     use crate::{
         common::ascii,
