Extract PyInt::to_str_radix_10() to deduplicate i64 fast path logic

youknowone · youknowone · commit 22f67632f0a8 · 2026-03-02T10:15:41.000+09:00
diff --git a/crates/vm/src/builtins/int.rs b/crates/vm/src/builtins/int.rs
@@ -267,6 +267,15 @@ impl PyInt {
         &self.value
     }
 
+    /// Fast decimal string conversion, using i64 path when possible.
+    #[inline]
+    pub fn to_str_radix_10(&self) -> String {
+        match self.value.to_i64() {
+            Some(i) => i.to_string(),
+            None => self.value.to_string(),
+        }
+    }
+
     // _PyLong_AsUnsignedLongMask
     pub fn as_u32_mask(&self) -> u32 {
         let v = self.as_bigint();
@@ -603,10 +612,7 @@ impl Comparable for PyInt {
 impl Representable for PyInt {
     #[inline]
     fn repr_str(zelf: &Py<Self>, _vm: &VirtualMachine) -> PyResult<String> {
-        Ok(match zelf.value.to_i64() {
-            Some(i) => i.to_string(),
-            None => zelf.value.to_string(),
-        })
+        Ok(zelf.to_str_radix_10())
     }
 }
 
diff --git a/crates/vm/src/protocol/object.rs b/crates/vm/src/protocol/object.rs
@@ -15,7 +15,6 @@ use crate::{
     protocol::PyIter,
     types::{Constructor, PyComparisonOp},
 };
-use num_traits::ToPrimitive;
 
 // RustPython doesn't need these items
 // PyObject *Py_NotImplemented
@@ -379,11 +378,7 @@ impl PyObject {
         // Fast path for exact int: skip __str__ method resolution
         let obj = match obj.downcast_exact::<PyInt>(vm) {
             Ok(int) => {
-                let s = match int.as_bigint().to_i64() {
-                    Some(i) => i.to_string(),
-                    None => int.as_bigint().to_string(),
-                };
-                return Ok(vm.ctx.new_str(s));
+                return Ok(vm.ctx.new_str(int.to_str_radix_10()));
             }
             Err(obj) => obj,
         };
