cmov: add miri support by forcing the portable backend#864
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Mar 24, 2023
Merged
cmov: add miri support by forcing the portable backend#864tarcieri merged 1 commit intoRustCrypto:masterfrom
miri support by forcing the portable backend#864tarcieri merged 1 commit intoRustCrypto:masterfrom
Conversation
Member
|
That's fine. If it gets any more gnarly we can use |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not too sure if these
cfgs are the most optimised - feel free to request any adjustments!Currently
miridoesn't have support for inline ASM, so any usage of thecmovcrate (on inline ASM-utilising architectures) causes a failure. I scouredmiri's docs for a solution, but this also works.I have tested these changes locally - all architectures build, and
miriworks too!I'm unsure whether or not this should be included in the README, it wasn't here but it's no hassle either way.