cmov: fix builds on x86 (32-bit) targets#863
Merged
tarcieri merged 3 commits intoRustCrypto:masterfrom Mar 24, 2023
Merged
Conversation
tarcieri
reviewed
Mar 24, 2023
Co-authored-by: Tony Arcieri <bascule@gmail.com>
x86 (32-bit) targets
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug with CI (#861) which meant build issues on any architecture that differs from the host (
x86_64I believe) were suppressed.I think this specific bug happens due to
x86registers not having the capacity to store anything >i32. To fix it, I re-used thecmovimplementation foru128, but re-purposed it specifically forx86andu64s.