Skip to content

Pre-PR cleanup#1

Merged
tedspare merged 19 commits intomainfrom
tedspare/cleanup
Aug 28, 2023
Merged

Pre-PR cleanup#1
tedspare merged 19 commits intomainfrom
tedspare/cleanup

Conversation

@tedspare
Copy link
Copy Markdown

What does this PR do?

  • Remove unused/commented code
  • Add comments explaining any complex code
  • Add error-handling and catch-alls
  • Add defensive null checks
  • Remove entire frontend and assets (unless needed @DexterStorey?)

Fixes # (issue)

n/a

Requirement/Documentation

n/a

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

[WIP]

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 4:10pm

@tedspare tedspare marked this pull request as ready for review August 28, 2023 02:43
@DexterStorey
Copy link
Copy Markdown

lets leave the frontend - this is a high value PR. LGTM

* brought api keys from admin to user level with app install

* rm logs
@DexterStorey
Copy link
Copy Markdown

this is gtg

@tedspare tedspare changed the title [WIP] Pre-PR cleanup Pre-PR cleanup Aug 28, 2023
@tedspare tedspare merged commit 8521295 into main Aug 28, 2023
@DexterStorey DexterStorey deleted the tedspare/cleanup branch August 28, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants