New keybinding view model and filtering#280
Merged
Conversation
Rewrote keybinding functionality with view model integration - Introduced `KeybindingsViewModel` for managing and resetting keybindings. - Added `KeyBindingsModel` to define keybinding configurations. - Updated `KeybindTextBox` to improve focus handling and read-only behavior. - Implemented `FunctionsKeyHelper` for managing keybinding-related utility logic. - Refactored `FunctionsMapper` to remove unused functions related to window scaling.
- Corrected bindings for "ScrollUp" and "ScrollDown" to use appropriate translation keys. - Fixed "RotateLeft" and "RotateRight" keybindings issues. - Added missing bindings for "Down" and adjusted logic for internal scroll key derivation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored the keybinding system to include a new
KeybindingsViewModelfor managing keybinding configurations and their resetting. The changes also include filtering keybindings, and updates to enhance focus handling and read-only behavior ofKeybindTextBox. Introduced utility logic for keybinding management viaFunctionsKeyHelperand removed functions related to window scaling fromFunctionsMapper.Motivation and Context
Allow users to search for keybindings in the view. Should be more maintainable with a viewodel.
How Has This Been Tested?
Only on macOS, needs Windows testing.
Screenshots (if appropriate):
Types of changes
Checklist: