Skip to content

feat: forbid time estimates in architect mode #9931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrubens merged 2 commits into from
Dec 9, 2025
Merged

feat: forbid time estimates in architect mode #9931

mrubens merged 2 commits into from
Dec 9, 2025

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Dec 9, 2025 •
edited by ellipsis-dev bot
Loading

Prohibit architect mode from providing level of effort time estimates

View task on Roo Code Cloud

Important

Architect mode now prohibits time estimates, focusing on actionable steps, with updates in mode.ts and multiple snapshot files.

  • Behavior:
    • Architect mode now explicitly prohibits providing time estimates for tasks, focusing on actionable steps instead.
    • Updated DEFAULT_MODES in mode.ts to include this restriction.
  • Snapshots:
    • Updated snapshots in add-custom-instructions/architect-mode-prompt.snap, add-custom-instructions/mcp-server-creation-disabled.snap, and add-custom-instructions/mcp-server-creation-enabled.snap to reflect the new restriction.
    • Similar updates in system-prompt/consistent-system-prompt.snap, system-prompt/with-computer-use-support.snap, and 8 other snapshot files.

This description was created by Ellipsis for 38468dc. You can customize this summary. It will automatically update as commits are pushed.

@roomote
Copy link
Contributor Author

roomote bot commented Dec 9, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The snapshot updates correctly reflect the source code change that adds a **CRITICAL:** instruction to the architect mode prohibiting time estimates. All 18 system-prompt tests pass.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 9, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2025
@mrubens
Copy link
Collaborator

mrubens commented Dec 9, 2025

@roomote can you fix the tests?

@roomote
Copy link
Contributor Author

roomote bot commented Dec 9, 2025 •
edited
Loading

Fixaroo Clock   See task on Roo Cloud

Fixed the reported issues. Updated 8 missing system-prompt snapshots. All local checks passed.

View commit | Revert commit

@mrubens mrubens marked this pull request as ready for review December 9, 2025 03:05
@mrubens mrubens requested review from jr and mrubens as code owners December 9, 2025 03:06
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 9, 2025
@mrubens mrubens merged commit 54a5265 into main Dec 9, 2025
19 checks passed
@mrubens mrubens deleted the feature/forbid-architect-time-estimates branch December 9, 2025 03:06
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 9, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 9, 2025
@dosubot dosubot bot added the Enhancement New feature or request label Dec 9, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Dec 9, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The PR correctly adds a **CRITICAL:** instruction to architect mode prohibiting time estimates. All 13 snapshot files are properly updated to reflect the source code change.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cte cte cte approved these changes

@mrubens mrubens Awaiting requested review from mrubens mrubens is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrubens @cte @hannesrudolph @roomote