refactor: consolidate ThinkingBudget components and fix disable handling #9930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atures - Enforce explicit supportsReasoningEffort capability flag for models to use reasoning effort - Having a reasoningEffort default property alone is no longer sufficient - Remove SimpleThinkingBudget component, consolidate into ThinkingBudget with 'none' option - Fix model-params to not fallback to model default when customReasoningEffort is 'disable' - Remove defaultTemperature from Roo provider config - Update all related tests for capability-based behavior
Contributor
Re-review complete for the latest commit (a74cd6e). No new issues were found in the updated reasoning-effort UI.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
- Restore shouldUseReasoningEffort fallback logic for models with reasoningEffort but no supportsReasoningEffort (fixes fixed-effort model variants like o3-high, o3-low, o4-mini-high, etc.) - Restore defaultTemperature: 0.7 for Roo provider - Update tests to reflect correct behavior
- 'disable' turns off reasoning entirely (enableReasoningEffort=false) - 'none' is a valid reasoning level that sends reasoning with value 'none' - Both display as 'None' in the UI but behave differently - Add 'disable' as synthetic option when reasoning is not required - Handle 'none' from capability arrays as legitimate reasoning level
daniel-lxs
approved these changes
Dec 9, 2025
mrubens
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate reasoning effort UI components and fix the "disable" option to properly override model defaults.
Changes
UI Component Consolidation
SimpleThinkingBudgetintoThinkingBudgetcomponentApiOptions.tsxBug Fix: "disable" Reasoning Effort
model-params.tsto not fallback to model default when user explicitly selects "disable"customReasoningEffortis set (including "disable"), use it directly instead of falling backTest Updates
Files Changed
webview-ui/src/components/settings/ThinkingBudget.tsx- Enhanced with "none" optionwebview-ui/src/components/settings/ApiOptions.tsx- Simplified renderingwebview-ui/src/components/settings/SimpleThinkingBudget.tsx- Deletedsrc/api/transform/model-params.ts- Fix disable fallback logic