Skip to content

Revert "Add support for Roo Code Cloud as an embeddings provider" #9602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrubens merged 1 commit into from
Nov 26, 2025
Merged

Revert "Add support for Roo Code Cloud as an embeddings provider" #9602

mrubens merged 1 commit into from
Nov 26, 2025

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Nov 26, 2025 •
edited by ellipsis-dev bot
Loading

Reverts #9543

This is causing the codebase_search tool to get included even when it's not configured, and I'm seeing my indexing get stuck in standby when it is configured.

Important

Reverts support for Roo Code Cloud as an embeddings provider, removing related code, tests, and UI elements.

  • Behavior:
    • Reverts support for Roo Code Cloud as an embeddings provider, removing it from codebaseIndexConfigSchema and codebaseIndexModelsSchema in codebase-index.ts.
    • Removes Roo Code Cloud authentication requirement from embeddings.json in multiple locales.
  • Tests:
    • Deletes roo.spec.ts test file for RooEmbedder.
    • Removes Roo Code Cloud related mocks and tests from config-manager.spec.ts.
  • Code:
    • Removes RooEmbedder class from embedders/roo.ts.
    • Removes Roo Code Cloud related logic from config-manager.ts.
    • Updates service-factory.ts to exclude RooEmbedder.
  • UI:
    • Removes Roo Code Cloud options from CodeIndexPopover.tsx.
    • Updates i18n files to remove Roo Code Cloud references in settings.json across multiple locales.

This description was created by Ellipsis for a869c4d. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners November 26, 2025 05:06
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 26, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 26, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Review Complete - No Issues Found

This is a clean revert of PR #9543 that removes the Roo Code Cloud embeddings provider. The revert properly removes all references to the "roo" provider across the codebase:

✅ Type definitions updated (removed "roo" from enums)
✅ Implementation files cleaned (RooEmbedder class and tests removed)
✅ Configuration handling reverted (default changed back to "openai")
✅ UI components updated (provider selection options removed)
✅ Translation strings removed across all locales
✅ All provider references are consistent

The changes are complete and no issues were identified during review.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the bug Something isn't working label Nov 26, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 26, 2025
@mrubens mrubens merged commit 3c989d3 into main Nov 26, 2025
20 checks passed
@mrubens mrubens deleted the revert-9543-rcc_embeddings branch November 26, 2025 05:08
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 26, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cte cte cte approved these changes

@roomote roomote[bot] roomote[bot] approved these changes

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrubens @cte