Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Nov 13, 2025

Reason

  • When include: ["reasoning.encrypted_content"] is sent for models without reasoning, OpenAI Responses API returns: Invalid request to Responses API. Please check your input parameters. - Encrypted content is not supported with this model.
  • Also, gpt-5-chat-latest only supports medium verbosity; setting low/high triggers: Invalid request to Responses API. Please check your input parameters. - Unsupported value: 'low' is not supported with the 'gpt-5-chat-latest' model. Supported values are: 'medium'.

Changes

Fixes #9225


Important

Gate encrypted_content inclusion to when reasoningEffort is set and remove verbosity support for gpt-5-chat-latest.

  • Behavior:
    • Gate encrypted_content inclusion to when reasoningEffort is set in OpenAiNativeHandler.buildRequestBody() and OpenAiNativeHandler.completePrompt().
    • Remove supportsVerbosity from gpt-5-chat-latest in openai.ts.
  • Verification:
    • Unit tests in openai-native.spec.ts pass.
    • Full test suite passes.

This description was created by Ellipsis for 46fc2e1. You can customize this summary. It will automatically update as commits are pushed.

…gEffort is set; prevent Responses API error on non-reasoning models. types: remove supportsVerbosity from gpt-5-chat-latest to avoid invalid verbosity error. Fixes #9225
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 13, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 13, 2025

Rooviewer Clock   See task on Roo Cloud

Review completed. No issues found.

The changes correctly address the reported bug by:

  • Gating encrypted_content inclusion to only when reasoningEffort is set, preventing errors for non-reasoning models
  • Removing supportsVerbosity from gpt-5-chat-latest to avoid invalid verbosity errors

Both changes are minimal, focused, and properly implemented across streaming and non-streaming code paths.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2025
@mrubens mrubens merged commit 7730c6f into main Nov 13, 2025
21 checks passed
@mrubens mrubens deleted the fix/gate-openai-native-encrypted-include branch November 13, 2025 14:29
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 13, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG] gpt-5-chat-latest unusable due to forced encrypted_reasoning in Responses API

3 participants