Gate XML out when native tool protocol is ON #9107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke tool protocol code-only; omit Tools catalog in native mode; update tests
Contributor
Re-review completed. All previously flagged issues have been resolved. No new issues identified.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
…L only; remove unused protocol param from getToolDescriptionsForMode; protocol selection via non-exported code constant; tests pass
- Add type-safe TOOL_PROTOCOL constants with derived ToolProtocol type - Extract getEffectiveProtocol() and isNativeProtocol() utility functions - Add getToolInstructionsReminder() helper to eliminate duplication - Remove repetitive protocol resolution patterns across 7 files - Remove unnecessary skipXmlReferences intermediate variables - All 142 prompt tests passing
When native tool calling is enabled, the guideline about formulating tool calls is no longer needed since the provider handles the formatting automatically. Only XML mode needs the explicit formatting instruction.
mrubens
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gate XML formatting out of system prompts when ToolProtocol = native
Summary
Tests