fix: auto-sync enableReasoningEffort with reasoning dropdown selection #8890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add useEffect to automatically enable reasoning when: - Non-'none' effort is selected in dropdown, OR - Model requires reasoning effort - Only sets flag to true when needed (doesn't force-disable for 'none') - Avoids noisy config writes and aligns with existing tests - Minor indentation fix for SelectValue
Contributor
Review CompleteNo issues found. The PR correctly implements auto-synchronization of |
mrubens
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes reasoning enablement synchronization for Roo provider by automatically setting
enableReasoningEffortbased on dropdown selection.Changes
useEffectto automatically enable reasoning when:truewhen needed (doesn't force-disable for 'none')SelectValueTesting
Related
Addresses issue where reasoning was not showing on the UI due to
enableReasoningEffortbeing false even when reasoning effort was selected in the dropdown.Important
Adds
useEffectinSimpleThinkingBudget.tsxto auto-enableenableReasoningEffortbased on dropdown selection or model requirements.useEffectinSimpleThinkingBudget.tsxto auto-enableenableReasoningEffortwhen a non-'none' effort is selected or model requires it.enableReasoningEffortfor 'none' selection.SelectValue.This description was created by
for e8f6b79. You can customize this summary. It will automatically update as commits are pushed.