Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Oct 6, 2025

Important

Add parentTaskId to telemetry schema and update ClineProvider to include it in telemetry data.

  • Telemetry Schema:
    • Add parentTaskId as an optional field in taskPropertiesSchema in telemetry.ts.
  • ClineProvider:
    • Update ClineProvider class in ClineProvider.ts to include parentTaskId when capturing telemetry data.

This description was created by Ellipsis for 2e548d9. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners October 6, 2025 13:31
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Enhancement New feature or request labels Oct 6, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 6, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a small improvement opportunity: validate taskId/parentTaskId as UUIDs in the telemetry schema to improve data quality and catch malformed IDs early. See inline suggestion.

Comment on lines 114 to +115
taskId: z.string().optional(),
parentTaskId: z.string().optional(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Schema validation quality. These IDs are generated UUIDs elsewhere; enforcing z.string().uuid() here will help catch malformed values and improve downstream analytics consistency.

Suggested change
taskId: z.string().optional(),
parentTaskId: z.string().optional(),
taskId: z.string().uuid().optional(),
parentTaskId: z.string().uuid().optional(),

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 6, 2025
@mrubens mrubens merged commit 28b642d into main Oct 6, 2025
22 of 23 checks passed
@mrubens mrubens deleted the include_parent_task_id_in_telemetry branch October 6, 2025 15:30
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Oct 6, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants