Fix: Improve WelcomeView styling and readability #7682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduced excessive padding from p-16 to p-6 - Removed excessive bold text throughout - Made provider cards more compact with smaller icons (32x32px) - Increased introduction text size from text-sm to text-base for better visibility - Centered the main greeting title - Improved visual hierarchy with proper text sizing and spacing - Added subtle borders and improved color contrast
| target="_blank" | ||
| rel="noopener noreferrer"> | ||
| <div className="w-10 h-10"> | ||
| <div className="w-8 h-8 flex-shrink-0"> |
Contributor
There was a problem hiding this comment.
The icon size reduction from 40x40px to 32x32px improves compactness, but have we considered the accessibility impact? Would it be worth making this configurable or ensuring it meets WCAG guidelines for minimum target sizes?
| </TabContent> | ||
| <div className="sticky bottom-0 bg-vscode-sideBar-background p-5"> | ||
| <div className="flex flex-col gap-1"> | ||
| <div className="sticky bottom-0 bg-vscode-sideBar-background p-4 border-t border-vscode-panel-border"> |
Contributor
There was a problem hiding this comment.
Great addition of the border-top here! To ensure sufficient contrast across all VSCode themes, could we verify that provides adequate visibility in both light and dark themes?
Removed the text-vscode-warningForeground class as it wasn't defined in index.css. The incentive text now uses default color which looks good.
mrubens
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the styling and readability of the WelcomeView component, addressing issues with excessive padding and bold text that made the interface look cluttered.
Changes Made
p-16top-6for better space utilizationfont-mediuminstead offont-boldfor a cleaner lookrounded-lgtorounded-mdtext-smtotext-basetext-vscode-foregroundBefore & After
Before
After
Testing