Move isToolAllowedForMode out of shared directory #10089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Review complete. No issues found. This PR cleanly moves Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isToolAllowedForModefunction doesn't need to be shared since it's not used by the webview, and if we want to extend the implementation for custom tools then it needs to be solely in the extension host.Important
Relocate
isToolAllowedForModetocore/tools/validateToolUseand update references and tests accordingly.isToolAllowedForModefromshared/modestocore/tools/validateToolUse.isToolAllowedForModeinpresentAssistantMessage.ts,getEnvironmentDetails.spec.ts,filter-tools-for-mode.ts,index.ts,native-tools-filtering.spec.ts,validateToolUse.spec.ts, andmodes.spec.ts.getEnvironmentDetails.spec.ts,native-tools-filtering.spec.ts,validateToolUse.spec.ts, andmodes.spec.tsto reflect the new location ofisToolAllowedForMode.isToolAllowedForModefromshared/modes.tsand adjust imports accordingly.This description was created by
for d49c40e. You can customize this summary. It will automatically update as commits are pushed.