Skip to content

feat: add metadata to error details dialog #10050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brunobergher merged 2 commits into from
Dec 15, 2025
Merged

feat: add metadata to error details dialog #10050

brunobergher merged 2 commits into from
Dec 15, 2025

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Dec 12, 2025 •
edited by ellipsis-dev bot
Loading

Adds extension version, provider, model, and repository information to the error details dialog to help users provide better bug reports with context.

Screenshot 2025-12-12 at 16 30 47 Screenshot 2025-12-12 at 16 31 02

Changes:

  • Prepends metadata to error details when showing the info dialog
  • Uses useExtensionState hook to get extension version and API configuration
  • Uses useSelectedModel hook to get current provider and model ID
  • Formats metadata with newlines for readability

Testing:

  • Existing ChatRow tests pass
  • Type checking passes
  • Linting passes

View task on Roo Code Cloud

Important

Adds metadata to error details in ErrorRow for improved bug reporting, using hooks to fetch and format data.

  • Behavior:
    • Adds metadata (extension version, provider, model, date/time) to error details in ErrorRow.
    • Uses useExtensionState to get extension version and API configuration.
    • Uses useSelectedModel to get provider and model ID.
    • Formats metadata with newlines for readability.
  • UI:
    • Updates ErrorRow to display formatted error details in a dialog.
    • Adjusts opacity of error details button for better visibility.
  • Testing:
    • Existing tests for ChatRow pass.
    • Type checking and linting pass.

This description was created by Ellipsis for 2a41704. You can customize this summary. It will automatically update as commits are pushed.

@roomote
feat: add metadata to error details dialog
6239dc4 
- Prepends extension version, provider, model, and repository info to error details
- Helps users provide better bug reports with context
- Uses useExtensionState and useSelectedModel hooks for data
@roomote
Copy link
Contributor Author

roomote bot commented Dec 12, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Review completed. No issues found.

The new changes add a date/time timestamp to the error metadata and improve the info button discoverability by making it slightly visible (opacity-30) by default.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 12, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 12, 2025
@cte
Copy link
Collaborator

cte commented Dec 12, 2025

In the screenshot there's no error message beyond 401 - is that the only thing we have in this case or should we dump the raw error message so it gets copied as well.

@brunobergher brunobergher marked this pull request as ready for review December 12, 2025 17:47
@brunobergher brunobergher requested review from cte and jr as code owners December 12, 2025 17:47
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Enhancement New feature or request labels Dec 12, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Dec 12, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Review completed. No issues found.

The implementation correctly adds metadata (date/time, extension version, provider, model) to error details for improved bug reporting. The hooks are used appropriately and the UI improvement for info button visibility is a nice touch.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@brunobergher
Copy link
Collaborator

brunobergher commented Dec 12, 2025 •
edited
Loading

We don't get more detail in the 401 I used to force that situation :(

The inline message is the custom one I added based on the HTTP status code.

@brunobergher brunobergher merged commit 5929e26 into main Dec 15, 2025
29 checks passed
@brunobergher brunobergher deleted the feature/error-details-metadata branch December 15, 2025 19:05
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 15, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 15, 2025
@cte cte mentioned this pull request Dec 16, 2025
Merged
@roomote roomote bot mentioned this pull request Dec 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens mrubens approved these changes

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cte @brunobergher @mrubens @hannesrudolph @roomote