Skip to content

chore(fuselage): Convert className to be optional on Topbar.ToolBox component #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 3 commits into from
Jan 4, 2022
Merged

chore(fuselage): Convert className to be optional on Topbar.ToolBox component #603

ggazzo merged 3 commits into from
Jan 4, 2022

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Dec 29, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@KevLehman KevLehman requested a review from ggazzo December 29, 2021 19:17
@KevLehman KevLehman mentioned this pull request Dec 29, 2021
Merged
@ghost
Copy link

ghost commented Dec 30, 2021 •
edited by ghost
Loading

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@ggazzo ggazzo merged commit 323366d into develop Jan 4, 2022
@ggazzo ggazzo deleted the chore/mark-classname-optional-on-topbartoolbox branch January 4, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KevLehman @ggazzo