Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Feb 15, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Closes #610

Further comments

Adapt MultiSelect to replace AutoComplete. Convert MultiSelect from js to tsx.

@tassoevan tassoevan changed the title improve(fuselage): MultiSelect feat(fuselage): MultiSelect Feb 16, 2022
@dougfabris dougfabris changed the title feat(fuselage): MultiSelect feat(fuselage): MultiSelect improvements Feb 16, 2022
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 18, 2022

This pull request fixes 2 alerts when merging 1312c74 into 5193110 - view on LGTM.com

fixed alerts:

  • 1 for Implicit operand conversion
  • 1 for Use of returnless function

@RocketChat RocketChat deleted a comment from lgtm-com bot Feb 18, 2022
@RocketChat RocketChat deleted a comment from lgtm-com bot Feb 18, 2022
@RocketChat RocketChat deleted a comment from lgtm-com bot Feb 18, 2022
@RocketChat RocketChat deleted a comment from lgtm-com bot Feb 18, 2022
@RocketChat RocketChat deleted a comment from lgtm-com bot Feb 18, 2022
@RocketChat RocketChat deleted a comment from lgtm-com bot Feb 18, 2022
@RocketChat RocketChat deleted a comment from lgtm-com bot Feb 18, 2022
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 18, 2022

This pull request fixes 2 alerts when merging 9ee50b1 into 5193110 - view on LGTM.com

fixed alerts:

  • 1 for Implicit operand conversion
  • 1 for Use of returnless function

@tassoevan tassoevan merged commit 900aae8 into develop Feb 21, 2022
@tassoevan tassoevan deleted the improve/MultiSelect-AutoComplete branch February 21, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MultiSelectFiltered: It does not support rendering custom list item and selected item

4 participants