You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❗ No coverage uploaded for pull request base (feat/federation-feat-1@0d3549e). Click here to learn what that means.
The diff coverage is n/a.
❗ Current head 0fae5cf differs from pull request most recent head 0ee9667. Consider uploading reports for the commit 0ee9667 to get more accurate results
@RocketChat/chat-engine the build is broken, but I believe it's a cache issue since there is no typecheck error executing this locally, how can I proceed with this?
@RocketChat/chat-engine the build is broken, but I believe it's a cache issue since there is no typecheck error executing this locally, how can I proceed with this?
I think the @rocket.chat/presence package is hitting a cache that it shouldn't, maybe because it is importing files from apps/meteor. So your changes to EventSignature are causing the service that was compiled without them to be invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The purpose of this PR is to add the Sync for Users' real names.
Jira: FED-12
Issue(s)
Steps to test or reproduce
Further comments