Skip to content

[NEW] Sync real names from federated users#27114

Merged
MarcosSpessatto merged 10 commits into
feat/federation-feat-1from
feat/federation-display-user-name
Nov 16, 2022
Merged

[NEW] Sync real names from federated users#27114
MarcosSpessatto merged 10 commits into
feat/federation-feat-1from
feat/federation-display-user-name

Conversation

@MarcosSpessatto

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

The purpose of this PR is to add the Sync for Users' real names.

Jira: FED-12

Issue(s)

Steps to test or reproduce

Further comments

@codecov

codecov Bot commented Oct 20, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (feat/federation-feat-1@0d3549e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0fae5cf differs from pull request most recent head 0ee9667. Consider uploading reports for the commit 0ee9667 to get more accurate results

Impacted file tree graph

@@                    Coverage Diff                    @@
##             feat/federation-feat-1   #27114   +/-   ##
=========================================================
  Coverage                          ?   41.01%           
=========================================================
  Files                             ?      833           
  Lines                             ?    18407           
  Branches                          ?     2047           
=========================================================
  Hits                              ?     7550           
  Misses                            ?    10569           
  Partials                          ?      288           
Flag Coverage Δ
e2e 41.01% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RocketChat RocketChat deleted a comment from lgtm-com Bot Oct 25, 2022
@RocketChat RocketChat deleted a comment from lgtm-com Bot Oct 25, 2022
@RocketChat RocketChat deleted a comment from lgtm-com Bot Oct 25, 2022
@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review October 25, 2022 13:16
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner October 25, 2022 13:16
@MarcosSpessatto

Copy link
Copy Markdown
Contributor Author

@RocketChat/chat-engine the build is broken, but I believe it's a cache issue since there is no typecheck error executing this locally, how can I proceed with this?

@pierre-lehnen-rc

Copy link
Copy Markdown
Contributor

@RocketChat/chat-engine the build is broken, but I believe it's a cache issue since there is no typecheck error executing this locally, how can I proceed with this?

I think the @rocket.chat/presence package is hitting a cache that it shouldn't, maybe because it is importing files from apps/meteor. So your changes to EventSignature are causing the service that was compiled without them to be invalid.

@MarcosSpessatto MarcosSpessatto requested review from a team as code owners November 16, 2022 16:44
@MarcosSpessatto MarcosSpessatto removed request for a team November 16, 2022 16:47
@MarcosSpessatto MarcosSpessatto removed the request for review from a team November 16, 2022 16:47
@MarcosSpessatto MarcosSpessatto merged commit 07384fe into feat/federation-feat-1 Nov 16, 2022
@MarcosSpessatto MarcosSpessatto deleted the feat/federation-display-user-name branch November 16, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants