Skip to content

[NEW] Matrix federation Users' typing event#27070

Merged
MarcosSpessatto merged 19 commits into
feat/federation-feat-1from
feat/federation-sprint-5
Nov 18, 2022
Merged

[NEW] Matrix federation Users' typing event#27070
MarcosSpessatto merged 19 commits into
feat/federation-feat-1from
feat/federation-sprint-5

Conversation

@MarcosSpessatto

@MarcosSpessatto MarcosSpessatto commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

This PR introduces the ability to enable the typing indicator, it's only possible to do that, by enabling the push ephemeral events in the bridge configuration file (yaml).

There is no option to enable it manually, strictly only in the configuration file.

Jira: FED-47

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto changed the title [NEW] Federation sprint 5 [NEW] Matrix federation Users' typing event Oct 17, 2022
@MarcosSpessatto MarcosSpessatto self-assigned this Oct 17, 2022
@MarcosSpessatto MarcosSpessatto changed the base branch from feat/federation-sprint-3 to feat/federation-feat-1 October 20, 2022 11:30
@codecov

codecov Bot commented Oct 20, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (feat/federation-feat-1@8fb3a4a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 29e90c5 differs from pull request most recent head 5f18147. Consider uploading reports for the commit 5f18147 to get more accurate results

Impacted file tree graph

@@                    Coverage Diff                    @@
##             feat/federation-feat-1   #27070   +/-   ##
=========================================================
  Coverage                          ?   41.86%           
=========================================================
  Files                             ?      808           
  Lines                             ?    17962           
  Branches                          ?     1985           
=========================================================
  Hits                              ?     7520           
  Misses                            ?    10156           
  Partials                          ?      286           
Flag Coverage Δ
e2e 41.86% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto added this to the 5.4.0 milestone Oct 20, 2022
Comment thread apps/meteor/server/modules/notifications/notifications.module.ts Outdated
@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review October 21, 2022 15:49
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner October 21, 2022 15:49
@alansikora alansikora force-pushed the feat/federation-sprint-5 branch from d803ef2 to 29e90c5 Compare November 12, 2022 16:37
Marcos Defendi added 2 commits November 16, 2022 13:20
Moving the notification (user typing) to the proper place
@MarcosSpessatto MarcosSpessatto requested review from a team as code owners November 16, 2022 16:30
@MarcosSpessatto MarcosSpessatto removed request for a team November 16, 2022 16:47
@MarcosSpessatto MarcosSpessatto merged commit c1a50b0 into feat/federation-feat-1 Nov 18, 2022
@MarcosSpessatto MarcosSpessatto deleted the feat/federation-sprint-5 branch November 18, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants