Skip to content

Chore: roomTypes: Stop mixing client and server code together #24536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierre-lehnen-rc merged 21 commits into from
Feb 22, 2022
Merged

Chore: roomTypes: Stop mixing client and server code together #24536

pierre-lehnen-rc merged 21 commits into from
Feb 22, 2022

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Feb 18, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@lgtm-com

This comment was marked as outdated.

Sign in to view
@debdutdeb debdutdeb changed the title [Chore] roomTypes: Stop mixing client and server code together Chore: roomTypes: Stop mixing client and server code together Feb 18, 2022
@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review February 21, 2022 05:07
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team and tassoevan February 21, 2022 05:09
@casalsgh casalsgh added this to the 4.5.0 milestone Feb 22, 2022
tassoevan
tassoevan approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pierre-lehnen-rc pierre-lehnen-rc merged commit 8bf7fef into develop Feb 22, 2022
@pierre-lehnen-rc pierre-lehnen-rc deleted the room-coordinator branch February 22, 2022 02:28
@pierre-lehnen-rc pierre-lehnen-rc mentioned this pull request Mar 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pierre-lehnen-rc @tassoevan @casalsgh