[IMPROVE] Purchase Type Filter for marketplace apps and Categories filter anchor refactoring #24454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the design of the category filter anchor from a button with an icon to a Select with a dynamic text inside
Implemented the logic necessary for the purchase type filter to work, inserted a necessary translation in the dictionary and made some changes to the app TS type so that it works as it should. The App TS type had purchaseType typed as 'unknown[]' and price as 'string'
I've refactored the categories filter Anchor from a select dropdown with boolean placeholders to a Button dropdown with improved looks and a selected categories counter.
…gn specs I've refactored the way the category filter anchor reacts to category selections. Now when no categories are selected the filter looks like a common fuselage select, but when there are selected categories it looks like a blue button with a white counter on it. Also solved some type errors.
ujorgeleite
suggested changes
Feb 15, 2022
ujorgeleite
reviewed
Feb 16, 2022
ujorgeleite
approved these changes
Feb 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Implemented a filter by purchase type(free or paid) component for the apps screen of the marketplace. Besides that, new entries on the dictionary, fixed some parts of the App type (purchaseType was typed as unknown and price as string), and created some helpers to work alongside the filter. Will be refactoring the categories filter anchor and then will open this PR for reviews.
Demo gif:
Refactored the categories filter anchor from a plain fuselage select to a select button with dynamic colors.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments