Skip to content

[IMPROVE] OTR system messages #24382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yash-rajpal merged 12 commits into from
Feb 17, 2022
Merged

[IMPROVE] OTR system messages #24382

yash-rajpal merged 12 commits into from
Feb 17, 2022

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Feb 1, 2022

Proposed changes (including videos or screenshots)

OTR system messages to indicate key refresh and joining chat to users.

Issue(s)

Steps to test or reproduce

Further comments

image

github-actions[bot]
github-actions bot previously requested changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added 2 .js files, please convert to ts(x).
app/otr/lib/constants.js
app/otr/server/methods/sendSystemMessages.js

@yash-rajpal yash-rajpal changed the title [Improve] OTR system messages [IMPROVE] OTR system messages Feb 1, 2022
github-actions[bot]
github-actions bot previously requested changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added 2 .js files, please convert to ts(x).
app/otr/lib/constants.js
app/otr/server/methods/sendSystemMessages.js

@github-actions github-actions bot dismissed stale reviews from themself February 2, 2022 15:12

js files removed

albuquerquefabio
albuquerquefabio reviewed Feb 3, 2022
View reviewed changes
albuquerquefabio
albuquerquefabio reviewed Feb 3, 2022
View reviewed changes
albuquerquefabio
albuquerquefabio reviewed Feb 3, 2022
View reviewed changes
albuquerquefabio
albuquerquefabio reviewed Feb 3, 2022
View reviewed changes
@yash-rajpal yash-rajpal force-pushed the improve/otr-system-message branch from 668fa32 to b5f9c10 Compare February 3, 2022 17:06
albuquerquefabio
albuquerquefabio approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@albuquerquefabio albuquerquefabio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@yash-rajpal yash-rajpal merged commit 7fed8ce into develop Feb 17, 2022
@yash-rajpal yash-rajpal deleted the improve/otr-system-message branch February 17, 2022 17:50
@pierre-lehnen-rc pierre-lehnen-rc mentioned this pull request Mar 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

+1 more reviewer

@albuquerquefabio albuquerquefabio albuquerquefabio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yash-rajpal @albuquerquefabio