Skip to content

Chore: Set Docker image tag to latest only when really latest #24366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 12 commits into from
Feb 1, 2022
Merged

Chore: Set Docker image tag to latest only when really latest #24366

sampaiodiego merged 12 commits into from
Feb 1, 2022

Conversation

@debdutdeb
Copy link
Member

@debdutdeb debdutdeb commented Jan 31, 2022

Signed-off-by: Debdut Chakraborty debdut.chakraborty@rocket.chat

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@debdutdeb
ci::docker: update latest tag iff context_version > current_stable
fa1792e 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb debdutdeb marked this pull request as draft January 31, 2022 15:41
@debdutdeb
ci: add version label to docker images, adapt workflow accordingly
7cbadea 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
ci::docker: consider version label non-existence
6357938 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb debdutdeb marked this pull request as ready for review January 31, 2022 16:27
@debdutdeb
ci: use git to get the latest tag
81542ff 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
ci: catch second non-rc tag from sorted list
3e930c9 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
ci: current_latest == github_ref_name if workflow is triggered by the…
05f9813 
… latest major.minor.patch release

Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb debdutdeb changed the title Chore: update docker image latest tag if release version is greater that current latest Chore: update docker image latest tag iff it **is** the latest release Jan 31, 2022
@debdutdeb debdutdeb changed the title Chore: update docker image latest tag iff it **is** the latest release Chore: update docker image latest tag iff it is the latest release Jan 31, 2022
@debdutdeb
remove version labels
133cdba 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
sampaiodiego
sampaiodiego requested changes Jan 31, 2022
View reviewed changes
@debdutdeb
ci: remove commented stuff
71717aa 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
ci: remove hardcoded repository name
0c90e15 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@sampaiodiego sampaiodiego changed the title Chore: update docker image latest tag iff it is the latest release Chore: Set Docker image tag to latest only when really latest Feb 1, 2022
@sampaiodiego sampaiodiego merged commit 5c6edf0 into develop Feb 1, 2022
@sampaiodiego sampaiodiego deleted the docker-push-to-latest-iff-latest branch February 1, 2022 00:40
@debdutdeb debdutdeb mentioned this pull request Feb 1, 2022
Closed
@pierre-lehnen-rc pierre-lehnen-rc mentioned this pull request Mar 1, 2022
Merged
@ankar84 ankar84 mentioned this pull request Apr 8, 2022
Closed
@elektro-wolle elektro-wolle mentioned this pull request Jun 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@debdutdeb @sampaiodiego