Regression: Fix OmnichannelAppSourceRoomIcon sizes #24322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
So, the actual size is OK (16x16) but the icon still looks bigger than the others 🤔 I believe it's not because of the code itself, but icons like the "email" one have a padding surrounding it 👀 not sure if that would be a problem cc @renatobecker @casalsgh |
Contributor
Author
This is because of SVG usage against PNG images designed by our Figma icons! Design people create icons with a safe padding on it, we get this image icons with this safe squared area on it.
|
murtaza98
approved these changes
Jan 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments