Skip to content

[IMPROVE] Show Channel Icons on Room Header & Info panels #24239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KevLehman merged 5 commits into from
Jan 20, 2022
Merged

[IMPROVE] Show Channel Icons on Room Header & Info panels #24239

KevLehman merged 5 commits into from
Jan 20, 2022

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Jan 20, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

Updates Omnichannel Header & room Info component to render the source info
Built on top of #24237

Issue(s)

Steps to test or reproduce

Further comments

@murtaza98 murtaza98 added this to the 4.4.0 milestone Jan 20, 2022
@KevLehman
Copy link
Member

KevLehman commented Jan 20, 2022

  • Icon is shown on sidebar
    image
  • Icon is shown on header
    image
  • Icon is shown on Room Info panel (Also, proper information on App source is shown)
    image

@KevLehman KevLehman changed the title [IMPROVE] Update Channel Icon & Room Header with omni-source Icon & info [IMPROVE] Show Channel Icons on Room Header & Info panels Jan 20, 2022
@KevLehman KevLehman merged commit 0afb8dc into develop Jan 20, 2022
@KevLehman KevLehman deleted the omni/source-icon branch January 20, 2022 20:16
@KevLehman KevLehman mentioned this pull request Jan 20, 2022
Closed
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevLehman KevLehman KevLehman approved these changes

@d-gubert d-gubert Awaiting requested review from d-gubert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@murtaza98 @KevLehman @d-gubert