Chore: Replace Blaze templates #24165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging e83231c into 1441feb - view on LGTM.com new alerts:
|
e83231c to
1adda60
Compare
1adda60 to
2ca85ce
Compare
31968f9 to
a1aec5b
Compare
ggazzo
approved these changes
Jan 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
It replaces some templates used by login and invitation flows with React components. It also drops
maintemplate, allowingappLayoutto just handle components now.Issue(s)
Steps to test or reproduce
Further comments
This is far from ideal, but it's a first major strike to finally replace Blaze. It should unlock our current works on onboarding flow (setup wizard, login, registration, invitation) e E2EE (tying the notifications to some React contexts).
appLayoutmight be overcomed by routing based on JSX (e.g. React Router or Wouter) now.