Skip to content

[NEW][EE] Allow to filter departments by Business Units on Livechat #24162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KevLehman merged 11 commits into from
Jan 20, 2022
Merged

[NEW][EE] Allow to filter departments by Business Units on Livechat #24162

KevLehman merged 11 commits into from
Jan 20, 2022

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Jan 13, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@murtaza98 murtaza98 mentioned this pull request Jan 13, 2022
Merged
@murtaza98 murtaza98 requested a review from a team January 13, 2022 11:18
renatobecker
renatobecker previously requested changes Jan 13, 2022
View reviewed changes
murtaza98 and others added 2 commits January 14, 2022 16:35
@murtaza98 @renatobecker
Apply suggestions from code review
c05f4fa 
Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
@murtaza98
Apply suggestions from code review
3326e2f
@CLAassistant
Copy link

CLAassistant commented Jan 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

KevLehman
KevLehman requested changes Jan 19, 2022
View reviewed changes
@casalsgh casalsgh added this to the 4.4.0 milestone Jan 19, 2022
@murtaza98 murtaza98 requested a review from KevLehman January 20, 2022 07:41
KevLehman
KevLehman requested changes Jan 20, 2022
View reviewed changes
@murtaza98 @KevLehman
Update app/livechat/server/api/v1/config.js
6b7aca7 
Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat>
@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2022

This pull request introduces 2 alerts when merging 6b7aca7 into 1a5d288 - view on LGTM.com

new alerts:

  • 2 for Syntax error

@murtaza98 murtaza98 requested a review from KevLehman January 20, 2022 14:24
@KevLehman KevLehman dismissed renatobecker’s stale review January 20, 2022 15:38

Dismising as code was updated

@KevLehman KevLehman changed the title [NEW][EE] Allow filtering departments using Business Units on Livechat Config API [NEW][EE] Allow to filter departments by Business Units on Livechat Jan 20, 2022
@KevLehman KevLehman merged commit c09cf33 into develop Jan 20, 2022
@KevLehman KevLehman deleted the omni/livechat-set-business-unit branch January 20, 2022 15:38
@murtaza98 murtaza98 mentioned this pull request Jan 24, 2022
Merged
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevLehman KevLehman KevLehman approved these changes

@renatobecker renatobecker Awaiting requested review from renatobecker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@murtaza98 @CLAassistant @KevLehman @renatobecker @casalsgh